Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improvements #3

Open
wants to merge 9 commits into
base: maven
Choose a base branch
from
Open

improvements #3

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
c04e43c
improvements
FrankHossfeld Jun 6, 2020
d79967f
update README.md
FrankHossfeld Jun 6, 2020
7e36379
update README.md & poms
FrankHossfeld Jun 6, 2020
2230906
improvements
FrankHossfeld Jun 7, 2020
da64b2a
define central version using flatten-m-p
FrankHossfeld Jun 10, 2020
ee43b62
rename organization
FrankHossfeld Jun 10, 2020
86c44a9
move distribution management to parent pom
FrankHossfeld Jun 10, 2020
c65187c
avoid deploy of test modules
FrankHossfeld Jun 10, 2020
8c640ac
remove maven.install.version
FrankHossfeld Jun 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .github/workflows/maven.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,16 @@ on: [push, pull_request]
jobs:
build:
runs-on: ubuntu-latest
strategy:
matrix:
java_version: [ 8 ]

steps:
- uses: actions/checkout@v2
- name: Set up ${{ matrix.java_version }}
uses: actions/setup-java@v1
FrankHossfeld marked this conversation as resolved.
Show resolved Hide resolved
with:
java-version: ${{ matrix.java_version }}

# TODO: cache dependencies (taking into accounts: Maven plugins, snapshots, etc.)

Expand Down
1 change: 1 addition & 0 deletions .mvn/maven.config
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
-Drevision=HEAD-SNAPSHOT
FrankHossfeld marked this conversation as resolved.
Show resolved Hide resolved
30 changes: 28 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
GWT Events
==========
GWT Event
=========

![GWT3/J2CL compatible](https://img.shields.io/badge/GWT3/J2CL-compatible-brightgreen.svg) [![License](https://img.shields.io/:license-apache-blue.svg)](http://www.apache.org/licenses/LICENSE-2.0.html) [![Chat on Gitter](https://badges.gitter.im/hal/elemento.svg)](https://gitter.im/gwtproject/gwt-modules) ![CI](https://github.com/gwtproject/gwt-events/workflows/CI/badge.svg)

A future-proof port of the `com.google.web.bindery.event.Event` GWT module,
with no dependency on `gwt-user` (besides the Java Runtime Emulation),
Expand Down Expand Up @@ -176,3 +178,27 @@ and then refactor your code from `GwtEvent` to `Event`).
import org.gwtproject.event.legacy.shared.EventHandler;
import org.gwtproject.event.legacy.shared.GwtEvent;
```

## Instructions

To build gwt-event:

* run `mvn clean install`
FrankHossfeld marked this conversation as resolved.
Show resolved Hide resolved

on the parent directory.

To run the j2cl tests:

* switch to the 'gwt-timer-j2cl-tests' directory
* run `mvn j2cl:clean` & `mvn j2cl:test`
FrankHossfeld marked this conversation as resolved.
Show resolved Hide resolved
FrankHossfeld marked this conversation as resolved.
Show resolved Hide resolved

**Note: To build the module you need Maven 3.6.3 or newer**
FrankHossfeld marked this conversation as resolved.
Show resolved Hide resolved

## System Requirements

**GWT Event requires GWT 2.9.0 or newer!**


## Dependencies

GWT Event does not depend on any other module.
56 changes: 20 additions & 36 deletions gwt-event-compat-gwt2-tests/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<parent>
<groupId>org.gwtproject.event</groupId>
<artifactId>gwt-event-parent</artifactId>
<version>HEAD-SNAPSHOT</version>
<version>${revision}</version>
</parent>
<artifactId>gwt-event-compat-gwt2-tests</artifactId>
<packaging>gwt-lib</packaging>
FrankHossfeld marked this conversation as resolved.
Show resolved Hide resolved
Expand All @@ -15,57 +15,24 @@
<description>Test cases for the GWT 2 tests</description>

<properties>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>

<maven.compiler.source>1.8</maven.compiler.source>
<maven.compiler.target>1.8</maven.compiler.target>

<maven.gwt.plugin>1.0.0</maven.gwt.plugin>

<!-- CI -->
<vertispan.j2cl.repo.url>https://repo.vertispan.com/j2cl/</vertispan.j2cl.repo.url>
<google.snapshot.repo.url>https://oss.sonatype.org/content/repositories/google-snapshots/</google.snapshot.repo.url>

<!-- <elemental2.version>1.0.0-RC1</elemental2.version>-->
<gwt.version>2.8.2</gwt.version>
<gwt.version>2.9.0</gwt.version>
<junit.version>4.12</junit.version>
</properties>

<dependencies>
<dependency>
<groupId>org.gwtproject.event</groupId>
<artifactId>gwt-event-compat</artifactId>
<version>HEAD-SNAPSHOT</version>
<version>${project.version}</version>
<scope>test</scope>
</dependency>

<!-- <dependency>-->
<!-- <groupId>com.google.gwt</groupId>-->
<!-- <artifactId>gwt-user</artifactId>-->
<!-- <version>${gwt.version}</version>-->
<!-- <scope>test</scope>-->
<!-- </dependency>-->
<!-- <dependency>-->
<!-- <groupId>com.google.gwt</groupId>-->
<!-- <artifactId>gwt-dev</artifactId>-->
<!-- <version>${gwt.version}</version>-->
<!-- <scope>test</scope>-->
<!-- </dependency>-->

<!-- <dependency>-->
<!-- <groupId>com.google.elemental2</groupId>-->
<!-- <artifactId>elemental2-dom</artifactId>-->
<!-- <version>${elemental2.version}</version>-->
<!-- <scope>test</scope>-->
<!-- </dependency>-->
<!-- <dependency>-->
<!-- <groupId>com.google.elemental2</groupId>-->
<!-- <artifactId>elemental2-dom</artifactId>-->
<!-- <version>${elemental2.version}</version>-->
<!-- <classifier>sources</classifier>-->
<!-- <scope>test</scope>-->
<!-- </dependency>-->

<dependency>
<groupId>junit</groupId>
<artifactId>junit</artifactId>
Expand All @@ -89,6 +56,23 @@
<plugin>
<groupId>com.mycila</groupId>
<artifactId>license-maven-plugin</artifactId>
<version>${maven.license.plugin}</version>
FrankHossfeld marked this conversation as resolved.
Show resolved Hide resolved
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-install-plugin</artifactId>
<version>${maven.install.plugin}</version>
<configuration>
<skip>true</skip>
</configuration>
</plugin>
<plugin>
FrankHossfeld marked this conversation as resolved.
Show resolved Hide resolved
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-deploy-plugin</artifactId>
<version>${maven.deploy.plugin}</version>
<configuration>
<skip>true</skip>
</configuration>
</plugin>
</plugins>
</build>
Expand Down
68 changes: 58 additions & 10 deletions gwt-event-compat/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,29 @@
<?xml version="1.0" encoding="UTF-8"?>
<!--

Copyright © 2017 The GWT Project

Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at

http://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.

-->
<project xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xmlns="http://maven.apache.org/POM/4.0.0"
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
<modelVersion>4.0.0</modelVersion>

<groupId>org.gwtproject.event</groupId>
<artifactId>gwt-event-compat</artifactId>
<version>HEAD-SNAPSHOT</version>
<version>${revision}</version>
<packaging>gwt-lib</packaging>

<name>GWT Compat Event</name>
Expand Down Expand Up @@ -43,11 +60,18 @@
<inceptionYear>2017</inceptionYear>

<properties>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>

<maven.compiler.source>1.8</maven.compiler.source>
<maven.compiler.target>1.8</maven.compiler.target>

<maven.compiler.plugin>3.8.1</maven.compiler.plugin>
<maven.deploy.plugin>3.0.0-M1</maven.deploy.plugin>
<maven.gpg.plugin>1.6</maven.gpg.plugin>
<maven.flatten.plugin>1.1.0</maven.flatten.plugin>
FrankHossfeld marked this conversation as resolved.
Show resolved Hide resolved
<maven.gwt.plugin>1.0.0</maven.gwt.plugin>
<maven.javadoc.plugin>3.1.1</maven.javadoc.plugin>
<maven.licence.plugin>3.0</maven.licence.plugin>
<maven.gpg.plugin>1.6</maven.gpg.plugin>
<maven.javadoc.plugin>3.2.0</maven.javadoc.plugin>
<maven.license.plugin>3.0</maven.license.plugin>
<maven.source.plugin>3.2.1</maven.source.plugin>

<gwt.version>2.9.0</gwt.version>
Expand Down Expand Up @@ -86,10 +110,10 @@
<plugin>
<groupId>com.mycila</groupId>
<artifactId>license-maven-plugin</artifactId>
<version>${maven.licence.plugin}</version>
<version>${maven.license.plugin}</version>
<configuration>
<header>LICENSE.header</header>
<encoding>UTF-8</encoding>
<encoding>${project.build.sourceEncoding}</encoding>
FrankHossfeld marked this conversation as resolved.
Show resolved Hide resolved
<skipExistingHeaders>true</skipExistingHeaders>
<mapping>
<java>SLASHSTAR_STYLE</java>
Expand All @@ -99,13 +123,12 @@
<exclude>**/LICENSE</exclude>
<exclude>**/LICENSE.header</exclude>
<exclude>**/AUTHORS</exclude>
<exclude>**/*.xml</exclude>
<exclude>src/test/resources/**</exclude>
<exclude>src/main/resources/**</exclude>
</excludes>
<properties>
<year>${project.inceptionYear}</year>
<name>The GWT Authors</name>
<name>${project.organization.name}</name>
FrankHossfeld marked this conversation as resolved.
Show resolved Hide resolved
</properties>
</configuration>
<executions>
Expand All @@ -125,10 +148,35 @@
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
<configuration>
<source>8</source>
<target>8</target>
<source>${maven.compiler.source}</source>
FrankHossfeld marked this conversation as resolved.
Show resolved Hide resolved
<target>${maven.compiler.target}</target>
</configuration>
</plugin>
<plugin>
<groupId>org.codehaus.mojo</groupId>
<artifactId>flatten-maven-plugin</artifactId>
FrankHossfeld marked this conversation as resolved.
Show resolved Hide resolved
<version>${maven.flatten.plugin}</version>
<configuration>
<updatePomFile>true</updatePomFile>
FrankHossfeld marked this conversation as resolved.
Show resolved Hide resolved
<flattenMode>resolveCiFriendliesOnly</flattenMode>
FrankHossfeld marked this conversation as resolved.
Show resolved Hide resolved
</configuration>
<executions>
<execution>
<id>flatten</id>
<phase>process-resources</phase>
<goals>
<goal>flatten</goal>
</goals>
</execution>
<execution>
<id>flatten.clean</id>
<phase>clean</phase>
<goals>
<goal>clean</goal>
</goals>
</execution>
</executions>
</plugin>
</plugins>
</build>

Expand Down
47 changes: 17 additions & 30 deletions gwt-event-gwt2-tests/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<parent>
<groupId>org.gwtproject.event</groupId>
<artifactId>gwt-event-parent</artifactId>
<version>HEAD-SNAPSHOT</version>
<version>${revision}</version>
</parent>
<artifactId>gwt-event-gwt2-tests</artifactId>
<packaging>gwt-lib</packaging>
FrankHossfeld marked this conversation as resolved.
Show resolved Hide resolved
Expand All @@ -26,39 +26,10 @@
<vertispan.j2cl.repo.url>https://repo.vertispan.com/j2cl/</vertispan.j2cl.repo.url>
<google.snapshot.repo.url>https://oss.sonatype.org/content/repositories/google-snapshots/</google.snapshot.repo.url>

<!-- <elemental2.version>1.0.0-RC1</elemental2.version>-->
<!-- <gwt.version>2.8.2</gwt.version>-->
<junit.version>4.12</junit.version>
</properties>

<dependencies>
<!-- <dependency>-->
<!-- <groupId>com.google.gwt</groupId>-->
<!-- <artifactId>gwt-user</artifactId>-->
<!-- <version>${gwt.version}</version>-->
<!-- <scope>test</scope>-->
<!-- </dependency>-->
<!-- <dependency>-->
<!-- <groupId>com.google.gwt</groupId>-->
<!-- <artifactId>gwt-dev</artifactId>-->
<!-- <version>${gwt.version}</version>-->
<!-- <scope>test</scope>-->
<!-- </dependency>-->

<!-- <dependency>-->
<!-- <groupId>com.google.elemental2</groupId>-->
<!-- <artifactId>elemental2-dom</artifactId>-->
<!-- <version>${elemental2.version}</version>-->
<!-- <scope>test</scope>-->
<!-- </dependency>-->
<!-- <dependency>-->
<!-- <groupId>com.google.elemental2</groupId>-->
<!-- <artifactId>elemental2-dom</artifactId>-->
<!-- <version>${elemental2.version}</version>-->
<!-- <classifier>sources</classifier>-->
<!-- <scope>test</scope>-->
<!-- </dependency>-->

<dependency>
<groupId>junit</groupId>
<artifactId>junit</artifactId>
Expand All @@ -83,6 +54,22 @@
<groupId>com.mycila</groupId>
<artifactId>license-maven-plugin</artifactId>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-install-plugin</artifactId>
<version>${maven.install.plugin}</version>
<configuration>
<skip>true</skip>
</configuration>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-deploy-plugin</artifactId>
<version>${maven.deploy.plugin}</version>
<configuration>
<skip>true</skip>
</configuration>
</plugin>
</plugins>
</build>
</project>
Loading