Adding the option to choose preferred domain #4916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdcapano
requested changes
Oct 30, 2024
kkacanja
force-pushed
the
kkacanja-wvdm
branch
from
f3d2c6f
to
502f52a
Compare
cdcapano
requested changes
Nov 8, 2024
|
added 3 commits
November 8, 2024 14:09
cdcapano
approved these changes
Nov 11, 2024
prayush
pushed a commit
to prayush/pycbc
that referenced
this pull request
Nov 21, 2024
* Adding the option to choose preferred domain * Updated logic * Syntax fix * Fixed imports * Stylistic changes --------- Co-authored-by: kkacanja <your.email@example.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Incorporated the option to set a preferred domain for waveform generation. This is useful for waveform models that are available in both frequency domain and time domain. Previously it automatically chose the frequency domain.
Example Usage:
[static-params]
preferred-domain = td
The options are td for time domain, fd for frequency domain, and none for default