-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pygrb injection plot formatting fixes #52
Pygrb injection plot formatting fixes #52
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @a-r-williamson. It looks all fine. Will wait for the other 3 tasks to be done before merging.
Yeah I need to test things properly too, it's not ready. |
Hi @a-r-williamson, you could make the found-missed plot look like the one from the all-sky search for consistency (gwastro/pycbc#3218). |
This PR is to address #54 |
1bb746a
to
b8a3c08
Compare
This commit also ensures found-missed and missed-found plots are made for the same combinations of variables
b8a3c08
to
1b25c04
Compare
Rebased to master after bugfix in #56. |
As of now the injection recovery plots have significant changes to their appearance. The changes so far incorporate:
Together these changes turn... |
Nice, you spared me some future work @a-r-williamson! |
This will need corresponding changes to the result page, which I'll make next. I believe all required changes will be in pycbc_make_grb_summary_page and within |
Hi @pannarale, are you happy with how this is now? |
There have been a few plotting bugs in need of squashing.
cividis
.