Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Sejsel, thank you for creating the log manager and for distributing the self-contained Linux version.
I have noticed that the
~/.net/ArcdpsLogManager
directory is re-created every time I launch your tool. This bothers me a little bit, since I like to keep my home directory clean. I've found that changingIncludeAllContentForSelfExtract
fromtrue
tofalse
for the build leads to this directory not being created and the application still working just fine.I have no idea why you chose to enable that option. I also don't know much about what this does, but my understanding is that this option makes sure that everything the application might need is included. Therefore I checked if disabling it removes anything important from the binary. I found that it only flips 1 bit, presumably the bit responsible for the extraction.
So my guess is that this change has no negative consequences.