Analytics: Fix processing failing if Emboldened is applied midfight

gw2scratch · Aug 22, 2023 · c435f69 · c435f69
1 parent 702b4ea
commit c435f69
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/EVTCAnalytics/Processing/Encounters/Modes/EmboldenedDetectingModeDeterminer.cs b/EVTCAnalytics/Processing/Encounters/Modes/EmboldenedDetectingModeDeterminer.cs
@@ -35,7 +35,13 @@ public class EmboldenedDetectingModeDeterminer : IModeDeterminer
 				}
 			}
 
-			var maxEmboldenedCount = emboldenedCounts.Values.Max();
+			// In case Emboldened appears only due to buff applications, we currently default to 0.
+			// Note that this can be both correct and wrong, depending on when this happens:
+			// - at the end of the fight, the log can capture the emboldened buff being applied (if coming from CM fight) / reset, we want to ignore this
+			// - in the middle of a fight, this can be legitimate when the emboldened wing changes to the one the fight is happening in, we want to count this
+			// TODO: fix this ^
+
+			var maxEmboldenedCount = emboldenedCounts.Values.DefaultIfEmpty(0).Max();
 			var mode = maxEmboldenedCount switch {
 				<= 0 => EncounterMode.Normal,
 				1 => EncounterMode.Emboldened1,