Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix uart_checker reading wrong characters #43

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lukamac
Copy link
Contributor

@lukamac lukamac commented Nov 15, 2024

Fixed

  • fix wrong characters being printed due to sampling frequency misalignments. Increasing the clock frequency of the uart_checker by 4 instead of 2 fixed it. This consequently doubles the number of enqueued events.

Changed

  • use enum for state holding instead of multiple bool flags
  • use std::putc for printing instead of std::cout
  • renamed rx_nb_bits to sent_bits and nb_bits to received_bits
  • renamed stdout to print_stdout to not clash with the global stdout

Removed

  • remove telnet since it was commented out anyway

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant