Error protection mode #28
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added an additional argument, giving functionality to an "error protection mode".
The advantage of this mode is that it makes the program much more robust in its error handling. Url Errors could cause problems or occasional make the program crash. These errors are from things like disconnects, such as when Bing refuses your request. These sort of errors are often random, and will occur server-side.
When you're trying to download a very large number of images, such as for machine learning projects, that can cause some obvious issues. Thus, I made the error protection mode wait for an appropriate amount of time and retry, while ensuring the total retry wait time doesn't wait longer than the timeout variable.
I've been testing it out, and this solution works pretty well!