-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move to SSM (from S3) for config/secrets #141
base: upgrade-node
Are you sure you want to change the base?
Conversation
b185f8e
to
8271565
Compare
IIRC this repository publishes libraries. In this PR we're adding some infrastructure; how would it differ from https://github.com/guardian/login.gutools? |
guardian/login.gutools is a play application that provides a minimal way to login (with panda) and also provides an emergency mode when Google is down. The infrastructure being added in this PR is to define some per stage SSM params (to ultimately replace the I'm working with @rtyley on this. |
Thanks for the context @twrichards, super helpful! The plan sounds good, and discrete enough from login.gutools too.
You might want to consider how to achieve IaC for this. https://github.com/guardian/private-infrastructure-config might be useful for keeping AWS account IDs (private information) out of this public repository. IIRC the current policy allows any IAM role in any of the listed accounts access. Might this be too broad, with an alternative being to list specific services? Maybe using tags to differentiate? |
Indeed I was planning on using guardian/private-infrastructure-config (in fact it was extra motivation to define this new infra with CDK - unlike https://github.com/guardian/editorial-tools-platform/blob/main/cloudformation/composer-account/login.gutools/login-tool.yaml). That's a good point about the broadness of access, I will explore using tags (to at least limit by Stage) it would be quite nice too, to have a single place where access is defined in all accounts - but I will try to strike a pragmatic balance. |
No description provided.