Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Zeitwerk reload issue #38

Merged
merged 5 commits into from
Aug 9, 2024
Merged

Fix Zeitwerk reload issue #38

merged 5 commits into from
Aug 9, 2024

Conversation

sanak
Copy link
Member

@sanak sanak commented Aug 8, 2024

Fix farend/redmine_message_customize#67

Changes proposed in this pull request:

@gtt-project/maintainer

@sanak sanak added the bug Something isn't working label Aug 8, 2024
@sanak sanak self-assigned this Aug 8, 2024
@sanak sanak changed the base branch from main to next August 8, 2024 11:21
@sanak
Copy link
Member Author

sanak commented Aug 8, 2024

Hmm...
Now Redmine 4.2 and master (6.0) seem to work fine, but bundle exec rake zeitwerk:check reports error in Redmine 5.0 and 5.1...
https://github.com/gtt-project/redmine_custom_fields_groups/actions/runs/10301118962/job/28511968966

NameError: uninitialized constant Issues::New
Did you mean?  News
               Net

I will try to solve the issue (or just skip zeitwerk:check) in Redmine 5.0 and 5.1 case, tomorrow.

@sanak
Copy link
Member Author

sanak commented Aug 9, 2024

@mopinfish (CC: @dkastl @smellman)
This is fix for the following message customize plugin's combination error in Redmine 5.1 environment.
farend/redmine_message_customize#67

I am thinking to create similar PR to redmine_gtt plugin side soon, so checking this is helpful.

@sanak
Copy link
Member Author

sanak commented Aug 9, 2024

@mopinfish @dkastl @smellman
Sorry, the last commit seems to reproduce the original issue again instead of passing zeitwerk:check test...
I will set draft mode for all related PRs. 🙇‍♂️

@sanak sanak marked this pull request as draft August 9, 2024 04:15
@sanak sanak marked this pull request as ready for review August 9, 2024 05:28
@sanak
Copy link
Member Author

sanak commented Aug 9, 2024

@mopinfish @dkastl @smellman
Well, I fixed previous commit issue with the following additional commit, so now this PR is ready for review.
commit diff: fb38723

I will set ready for other PRs as well.

Copy link

@mopinfish mopinfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sanak
Copy link
Member Author

sanak commented Aug 9, 2024

Thanks!
I will merge this.

@sanak sanak merged commit c3af621 into next Aug 9, 2024
33 checks passed
@dkastl dkastl deleted the fix/zeitwerk-reload-issue branch August 9, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"find_or_default" error when reloading with some plugins which use "deface" gem in Redmine 5.1 environment
2 participants