-
-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
glib: Add helper functions to spawn a non-Send
future on the curren…
#902
Open
sdroege
wants to merge
1
commit into
gtk-rs:main
Choose a base branch
from
sdroege:main-context-spawn
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -552,6 +552,36 @@ impl Spawn for MainContext { | |
} | ||
} | ||
|
||
// rustdoc-stripper-ignore-next | ||
/// Spawns an infallible, non-`Send` on the current thread-default [`MainContext`]. | ||
/// | ||
/// Panics if there is no thread-default main context on this thread and if this thread | ||
/// does not own the global default main context. | ||
pub fn spawn<R: 'static, F: Future<Output = R> + 'static>(f: F) -> JoinHandle<R> { | ||
spawn_with_priority(crate::PRIORITY_DEFAULT, f) | ||
} | ||
|
||
// rustdoc-stripper-ignore-next | ||
/// Spawns an infallible, non-`Send` on the current thread-default [`MainContext`] with a | ||
/// non-default priority. | ||
/// | ||
/// Panics if there is no thread-default main context on this thread and if this thread | ||
/// does not own the global default main context. | ||
pub fn spawn_with_priority<R: 'static, F: Future<Output = R> + 'static>( | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. shouldn't this be named spawn_local_with_priority? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. same for above |
||
priority: Priority, | ||
f: F, | ||
) -> JoinHandle<R> { | ||
let ctx = MainContext::thread_default().unwrap_or_else(|| { | ||
let ctx = MainContext::default(); | ||
assert!( | ||
ctx.is_owner(), | ||
"Current thread does not own the default main context and has no thread-default main context", | ||
); | ||
ctx | ||
}); | ||
ctx.spawn_local_with_priority(priority, f) | ||
} | ||
|
||
impl LocalSpawn for MainContext { | ||
fn spawn_local_obj(&self, f: LocalFutureObj<'static, ()>) -> Result<(), SpawnError> { | ||
let (tx, _) = oneshot::channel(); | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The naming of the functions is a bit suboptimal as there's also this set of functions: https://gtk-rs.org/gtk-rs-core/git/docs/glib/fn.spawn_async.html
Any suggestions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
spawn_main_context
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or directly make these two functions methods of
MainContext
and add doc aliases on them.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are already methods with that name on
MainContext
. The goal here is to have a function that gets the correct main context instance and then calls the method on that.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
spawn_on_thread_default_main_context()
could work of course, but that's almost as long as the implementation of the function :)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe could move this into a
glib::futures
module, and also potentially move some other things in there. Not sure.