Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

glib: Rework signal class handlers and accumulators #611

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

glib: Rework signal class handlers and accumulators #611

wants to merge 5 commits into from

Conversation

jf2048
Copy link
Member

@jf2048 jf2048 commented Mar 15, 2022 •
edited
Loading

Fixes #365

We can't pass a closure directly in to class_handler or override_signal_class_handler because of safety issues, but we can use another simple macro

@jf2048 jf2048 force-pushed the signal-closures branch 4 times, most recently from 11f706d to 1d00e5c Compare March 15, 2022 05:05
sdroege
sdroege reviewed Mar 15, 2022
View reviewed changes
Copy link
Member

@sdroege sdroege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me otherwise

@jf2048 jf2048 marked this pull request as ready for review March 19, 2022 19:26
@jf2048 jf2048 marked this pull request as draft April 3, 2022 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdroege sdroege sdroege left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add closure variant of SignalBuilder::class_handler(), use Value traits for accumulator()
2 participants
@jf2048 @sdroege