Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tiny] Remove GRIST_SKIP_REDIS_CHECKSUM_MISMATCH #1098

Conversation

fflorent
Copy link
Collaborator

@fflorent fflorent commented Jul 10, 2024

Fixes #751

As discussed in the issue, skipping the redis checksum mismatch is now generalized. A warning is logged when we see a mismatch.

@fflorent fflorent force-pushed the remove-GRIST_SKIP_REDIS_CHECKSUM_MISMATCH branch from c3bd9dd to 8ab117f Compare July 10, 2024 17:42
Skipping the redis checksum mismatch is now generalized. A warning is
logged when we see a mismatch.
@fflorent fflorent force-pushed the remove-GRIST_SKIP_REDIS_CHECKSUM_MISMATCH branch from 8ab117f to 7bee41c Compare July 10, 2024 17:43
Copy link
Member

@paulfitz paulfitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for following up @fflorent

@paulfitz paulfitz merged commit 39eb042 into gristlabs:main Jul 10, 2024
12 checks passed
@fflorent fflorent deleted the remove-GRIST_SKIP_REDIS_CHECKSUM_MISMATCH branch July 12, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stop using Redis to track the expected version of a document in s3
2 participants