-
Notifications
You must be signed in to change notification settings - Fork 624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Seperates linting/Rust into linting/{Rust, Rust-Typos, Rust-Audit} #1759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. OpenSSF Scorecard
Scanned Files |
Given the nature of using NASL to identify vulnerabilities we may cannot get rif of all audit findings. To indicate that the CI fails based on an audit, rather than e.g. a clippy warning, cargo audit is seperated into an own job. Since the same may be true for typos, typos are seperated into an own job as well. With that change we can immediately see if a CI of a PR failed because of audit, typos or Rust linting issues.
nichtsfrei
force-pushed
the
minor-ci-changes
branch
from
November 11, 2024 10:10
81413ae
to
227c1c9
Compare
Tehforsch
approved these changes
Nov 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given the nature of using NASL to identify vulnerabilities we may cannot
get rif of all audit findings. To indicate that the CI fails based on an
audit, rather than e.g. a clippy warning, cargo audit is seperated into
an own job.
Since the same may be true for typos, typos are seperated into an own
job as well.
With that change we can immediately see if a CI of a PR failed because
of audit, typos or Rust linting issues.