-
Notifications
You must be signed in to change notification settings - Fork 624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial proposal of a Dev container #1711
Open
nichtsfrei
wants to merge
5
commits into
main
Choose a base branch
from
add-dev-container
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nichtsfrei
force-pushed
the
add-dev-container
branch
from
September 5, 2024 08:07
cffec07
to
628b510
Compare
nichtsfrei
force-pushed
the
add-dev-container
branch
from
September 20, 2024 11:39
628b510
to
4db93ae
Compare
nichtsfrei
force-pushed
the
add-dev-container
branch
from
October 15, 2024 07:56
4d469eb
to
9f5576a
Compare
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. OpenSSF Scorecard
Scanned Files |
nichtsfrei
force-pushed
the
add-dev-container
branch
from
November 11, 2024 09:26
9f5576a
to
41e93ea
Compare
nichtsfrei
added
no_release
Disable automatic release label creation
and removed
patch_release
creates a patch release
labels
Nov 11, 2024
nichtsfrei
force-pushed
the
add-dev-container
branch
from
November 11, 2024 09:27
41e93ea
to
c6c108b
Compare
As more and more people are using VSCode on a non linux machine we would like to make it easier to start developing on openvas as a whole. With this and an extension `Dev Container` a developer can work within an already setup environment. Additionally it is designed so that someone on a linux machine can also use it with Distrobox or with a direct mounted docker command. For that the GID as well as UID can be set via build parameter for convenience there is a Makefile creating the image with shared UID and GID gatherred from `id`. To build a new image for those purposes run `make build`. Inside the container there a multiple helper integrated, run: - start_redis -- to start a redis instance for openvas-scanner - greenbone-nvt-sync -- to get a community feed - build-openvas -- to rebuild openvas-scanner - build-gvm-libs -- to rebuild gvm-libs Additionally there are github specialized clone helper scripts, for an example executing: - github-clone greenbone/openvas-scanner - github-clone greenbone/gvm-libs will clone the openvas-scanner into /workspaces/greenbone/openvas-scanner and /workspaces/greenbone/gvm-libs respectively so that they can be immediately found by the build- scripts.
When figuring out if ssh should be used then the ls check should be in `$HOME/.ssh` not in the execution directory of `github-clone.sh`.
nichtsfrei
force-pushed
the
add-dev-container
branch
from
November 11, 2024 12:02
c6c108b
to
1fb058a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As more and more people are using VSCode on a non linux machine we would
like to make it easier to start developing on openvas as a whole.
With this and an extension
Dev Container
a developer can work withinan already setup environment.
Additionally it is designed so that someone on a linux machine can also
use it with Distrobox or with a direct mounted docker command.
For that the GID as well as UID can be set via build parameter for
convenience there is a Makefile creating the image with shared UID and
GID gatherred from
id
.To build a new image for those purposes run
make build
.Inside the container there a multiple helper integrated, run:
Additionally there are github specialized clone helper scripts, for an
example executing:
will clone the openvas-scanner into
/workspaces/greenbone/openvas-scanner and /workspaces/greenbone/gvm-libs
respectively so that they can be immediately found by the build-
scripts.