Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the request of @martinling, here's a draft PR that implements RAW_IO on Windows, using libusb/libusb#1512. The change checks if RAW_IO is available, and if it is, it turns it on for the
RX_ENDPOINT_ADDRESS
. I've made it silently ignore the result oflibusb_endpoint_set_raw_io
, since in the unlikely event of the call not working, I'd think we should continue on anyway.This change fixes sample drops on problematic Windows machines. I've marked the PR a draft because this change will require
#if LIBUSB_API_VERSION >= 0x0100010B ... #endif
to prevent issues when building with older versions of LibUSB. The problem is:LIBUSB_API_VERSION
has not been bumped yet. It's still sitting at 0x0100010A, so there's no good way to detect the presence of this functionWhile we wait for upstream devs, let me know if you'd like to see any changes to this!