-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
introduces mapSchemaConfig utility function #4297
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for compassionate-pike-271cb3 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Hi @yaacovCR, I'm @github-actions bot happy to help you with this PR 👋 Supported commandsPlease post this commands in separate comments and only one per comment:
|
e747264
to
23e7952
Compare
note: diff is easier to scan when hiding whitespace |
bf0cbb1
to
f6325d3
Compare
Just poking around a bit with deopt-explorer, which, as usual, is beyond me, but the summary for main is: and the summary for map is: For clarity, within the map version, we rename For clarity, I also renamed So the thing that leaps out at me is that the number of deoptimizations in |
UPDATE:
Benchmark results from current version are even better than before, an ~80% improvement on main: |
746c3af
to
019b6a9
Compare
motivation: 1. can be used to extract common logic from extendSchemaImpl and lexicographicSortSchema 2. can be used further enhance extendSchemaImpl to take resolvers 3. can be exposed to provide a generic safe mapSchemaConfig
This comment has been minimized.
This comment has been minimized.
@yaacovCR The latest changes of this PR are available on NPM as Also you can depend on latest version built from this PR: |
motivation:
lexicographicSortSchema()
on this generic utility, better demonstrating only the sortingextendSchemaImpl()
on this utilityextendSchema()
/buildASTSchema()
/buildSchema()
to take resolvers, etcmapSchemaConfig()
utilitybuildSchema()
.