[16.0][MIG] mrp_sale_grouped #376

quentinDupont · 2024-06-19T10:46:15Z

No description provided.

legalsylvain · 2024-06-19T12:03:36Z

Hello ! Vu l'historique, j'ai l'impression que tu n'utilises pas odoo-tools-grap. Un soucis ?
Bise !

quentinDupont · 2024-06-20T07:55:05Z

Hello ! Vu l'historique, j'ai l'impression que tu n'utilises pas odoo-tools-grap. Un soucis ? Bise !

oupsi faut que je prenne l'habitude, j'ai utilisé odoo-module-migrate !

legalsylvain · 2024-06-20T12:46:30Z

oupsi faut que je prenne l'habitude, j'ai utilisé odoo-module-migrate !

T'es so 2023.

codecov · 2024-06-20T13:34:37Z

Codecov Report

Attention: Patch coverage is 72.97297% with 70 lines in your changes missing coverage. Please review.

Project coverage is 72.97%. Comparing base (743d452) to head (1be9a7f).
Report is 36 commits behind head on 16.0.

❗ Current head 1be9a7f differs from pull request most recent head 7d25032

Please upload reports for the commit 7d25032 to get more accurate results.

Files	Patch %	Lines
mrp_sale_grouped/report/report_sale_grouped.py	22.72%	34 Missing ⚠️
...e_grouped/wizard/bom_print_purchase_list_wizard.py	74.24%	9 Missing and 8 partials ⚠️
mrp_sale_grouped/models/mrp_sale_grouped.py	83.67%	8 Missing ⚠️
...rp_sale_grouped/wizard/x2m_matrix_grouped_sales.py	54.54%	4 Missing and 1 partial ⚠️
mrp_sale_grouped/models/sale_order_line.py	71.42%	2 Missing ⚠️
mrp_sale_grouped/wizard/sale_grouped_wizard.py	91.30%	1 Missing and 1 partial ⚠️
...rp_sale_grouped/wizard/sale_grouped_wizard_line.py	81.81%	2 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##             16.0     #376       +/-   ##
===========================================
- Coverage   90.07%   72.97%   -17.11%     
===========================================
  Files          10       14        +4     
  Lines         262      259        -3     
  Branches       43       37        -6     
===========================================
- Hits          236      189       -47     
- Misses         17       60       +43     
- Partials        9       10        +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

legalsylvain · 2024-06-21T09:41:22Z

tu peux rebase du coup.

legalsylvain

nettoyage de printemps ? je sais pas si cette PR est en draft, mais y'a plein de code commenté. .. -;)

legalsylvain · 2024-06-21T07:18:09Z

mrp_sale_grouped/__manifest__.py

+        # "sale_mrp_link",
+        # GRAP


Suggested change

# "sale_mrp_link",

# GRAP

legalsylvain · 2024-06-21T09:41:57Z

mrp_sale_grouped/models/mrp_sale_grouped.py

+    # Quick access to MRP Production Orders
+    # mrp_production_ids = fields.One2many(
+    #     comodel_name="mrp.production", compute="_compute_mrp_production_ids"
+    # )
+    #
+    # mrp_production_qty = fields.Integer(
+    #     compute="_compute_production_qty",
+    # )


Suggested change

# Quick access to MRP Production Orders

# mrp_production_ids = fields.One2many(

# comodel_name="mrp.production", compute="_compute_mrp_production_ids"

# )

#

# mrp_production_qty = fields.Integer(

# compute="_compute_production_qty",

# )

legalsylvain · 2024-06-21T09:42:07Z

mrp_sale_grouped/models/mrp_sale_grouped.py

+    # production_state = fields.Selection(
+    #     selection=_PROD_STATE_SELECTION,
+    #     string="Production State",
+    #     default="prod_in_progress",
+    #     tracking=True,
+    #     compute="_compute_production_state",
+    # )


Suggested change

# production_state = fields.Selection(

# selection=_PROD_STATE_SELECTION,

# string="Production State",

# default="prod_in_progress",

# tracking=True,

# compute="_compute_production_state",

# )

legalsylvain · 2024-06-21T09:42:21Z

mrp_sale_grouped/models/mrp_sale_grouped.py

+    #
+    # @api.depends("mrp_production_ids")
+    # def _compute_production_state(self):
+    #     for mrp_sale_grouped in self:
+    #         if any(
+    #             prods.state not in ["done", "cancel"]
+    #             for prods in mrp_sale_grouped.mapped("mrp_production_ids")
+    #         ):
+    #             mrp_sale_grouped.production_state = "prod_in_progress"
+    #         else:
+    #             mrp_sale_grouped.production_state = "all_production_done"


Suggested change

#

# @api.depends("mrp_production_ids")

# def _compute_production_state(self):

# for mrp_sale_grouped in self:

# if any(

# prods.state not in ["done", "cancel"]

# for prods in mrp_sale_grouped.mapped("mrp_production_ids")

# ):

# mrp_sale_grouped.production_state = "prod_in_progress"

# else:

# mrp_sale_grouped.production_state = "all_production_done"

legalsylvain · 2024-06-21T09:42:34Z

mrp_sale_grouped/models/mrp_sale_grouped.py

+    # MRP Production
+    # @api.depends("order_ids")
+    # def _compute_mrp_production_ids(self):
+    #     for grouped_prod in self:
+    #         # production_ids is a sale_mrp_link field
+    #         grouped_prod.mrp_production_ids = grouped_prod.order_ids.mapped(
+    #             "production_ids"
+    #         )
+    #
+    # @api.depends("mrp_production_ids")
+    # def _compute_production_qty(self):
+    #     for grouped_prod in self:
+    #         grouped_prod.mrp_production_qty = len(grouped_prod.mrp_production_ids)


Suggested change

# MRP Production

# @api.depends("order_ids")

# def _compute_mrp_production_ids(self):

# for grouped_prod in self:

# # production_ids is a sale_mrp_link field

# grouped_prod.mrp_production_ids = grouped_prod.order_ids.mapped(

# "production_ids"

# )

#

# @api.depends("mrp_production_ids")

# def _compute_production_qty(self):

# for grouped_prod in self:

# grouped_prod.mrp_production_qty = len(grouped_prod.mrp_production_ids)

quentinDupont · 2024-06-21T09:50:27Z

nettoyage de printemps ? je sais pas si cette PR est en draft, mais y'a plein de code commenté. .. -;)

Ouais c'est ce que j'ai écris dans la ROADMAP

I had to comment all fields related to module sale_mrp_link that has been deprecated and replace by mrp_sale_info

Faut que je me plonge dans comment ça marche ce mrp_sale_info, mais en attendant, le reste marchait, donc je me suis concentré là dessus. Mais yes, draft

quentinDupont force-pushed the 16.0-MIG-mrp_sale_grouped-LAITEUX-QD branch from 6b00afb to 7ebe224 Compare June 20, 2024 12:31

legalsylvain reviewed Jun 21, 2024

View reviewed changes

quentinDupont marked this pull request as draft June 21, 2024 09:47

quentinDupont added 4 commits June 21, 2024 11:56

[IMP] mrp_sale_grouped: pre-commit execution

66ecf11

fix precommit and conflict

26528cc

fix tests

93ac046

fixup

58aa65f

quentinDupont force-pushed the 16.0-MIG-mrp_sale_grouped-LAITEUX-QD branch from 1be9a7f to 58aa65f Compare June 21, 2024 10:02

fixup

7d25032

legalsylvain added this to the 16.0 milestone Nov 15, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[16.0][MIG] mrp_sale_grouped #376

[16.0][MIG] mrp_sale_grouped #376

quentinDupont commented Jun 19, 2024

legalsylvain commented Jun 19, 2024

quentinDupont commented Jun 20, 2024

legalsylvain commented Jun 20, 2024

codecov bot commented Jun 20, 2024 •

edited

Loading

legalsylvain commented Jun 21, 2024

legalsylvain left a comment

legalsylvain Jun 21, 2024

legalsylvain Jun 21, 2024

legalsylvain Jun 21, 2024

legalsylvain Jun 21, 2024

legalsylvain Jun 21, 2024

quentinDupont commented Jun 21, 2024 •

edited

Loading

[16.0][MIG] mrp_sale_grouped #376

Are you sure you want to change the base?

[16.0][MIG] mrp_sale_grouped #376

Conversation

quentinDupont commented Jun 19, 2024

legalsylvain commented Jun 19, 2024

quentinDupont commented Jun 20, 2024

legalsylvain commented Jun 20, 2024

codecov bot commented Jun 20, 2024 • edited Loading

Codecov Report

legalsylvain commented Jun 21, 2024

legalsylvain left a comment

Choose a reason for hiding this comment

legalsylvain Jun 21, 2024

Choose a reason for hiding this comment

legalsylvain Jun 21, 2024

Choose a reason for hiding this comment

legalsylvain Jun 21, 2024

Choose a reason for hiding this comment

legalsylvain Jun 21, 2024

Choose a reason for hiding this comment

legalsylvain Jun 21, 2024

Choose a reason for hiding this comment

quentinDupont commented Jun 21, 2024 • edited Loading

codecov bot commented Jun 20, 2024 •

edited

Loading

quentinDupont commented Jun 21, 2024 •

edited

Loading