Add integration test workflow #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamyeats
added
datasource/SurrealDB
github-actions
adamyeats
force-pushed
the
main
branch
2 times, most recently
from
1206b5f
to
adf2e2c
Compare
adamyeats
force-pushed
the
integration-tests
branch
4 times, most recently
from
a4405c5
to
a30d963
Compare
adamyeats
force-pushed
the
integration-tests
branch
2 times, most recently
from
3d210b2
to
f0624e9
Compare
adamyeats
force-pushed
the
integration-tests
branch
from
f0624e9
to
8c862c0
Compare
adamyeats
requested review from
a team,
asimpson,
bossinc,
aangelisc and
alyssabull
and removed request for
a team
aangelisc
reviewed
Mar 22, 2024
aangelisc
reviewed
Mar 22, 2024
| instance, err := createTestInstance() | ||
|
|
||
| if err != nil { | ||
| t.Errorf("unexpected error: %s", err) |
There was a problem hiding this comment.
The only nit from me is to not use conditions to cause the tests to error but instead use the assert and require testing functions. Wdyt?
There was a problem hiding this comment.
Those require testify though right?
There was a problem hiding this comment.
Yep, feel free to ignore the suggestion I just think it'll improve the readability 😊
aangelisc
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds integration tests for the datasource. Part of https://github.com/grafana/oss-plugin-partnerships/issues/845.