Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Playwright E2E tests #129

Merged
merged 2 commits into from
Mar 19, 2024
Merged

Add Playwright E2E tests #129

merged 2 commits into from
Mar 19, 2024

Conversation

adamyeats
Copy link
Collaborator

No description provided.

@adamyeats adamyeats self-assigned this Feb 29, 2024
@adamyeats adamyeats requested review from a team, asimpson, bossinc, aangelisc and alyssabull and removed request for a team February 29, 2024 16:52
@adamyeats adamyeats marked this pull request as draft February 29, 2024 16:53
@adamyeats adamyeats force-pushed the playwright-e2e branch 6 times, most recently from 4ed7b32 to d04c5b5 Compare February 29, 2024 18:21
aangelisc
aangelisc reviewed Feb 29, 2024
View reviewed changes
.github/workflows/ci.yml Outdated Show resolved Hide resolved
aangelisc
aangelisc reviewed Feb 29, 2024
View reviewed changes
playwright.config.ts Outdated Show resolved Hide resolved
aangelisc
aangelisc reviewed Feb 29, 2024
View reviewed changes
Copy link
Contributor

@aangelisc aangelisc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking really good to me! Some nits/questions in the comments

@adamyeats adamyeats force-pushed the playwright-e2e branch 7 times, most recently from 129eb5f to c9bfdf5 Compare March 15, 2024 21:50
@adamyeats adamyeats force-pushed the playwright-e2e branch 21 times, most recently from 18c8530 to 74bcfc1 Compare March 18, 2024 18:51
@adamyeats adamyeats marked this pull request as ready for review March 19, 2024 13:17
asimpson
asimpson approved these changes Mar 19, 2024
View reviewed changes
Copy link

@asimpson asimpson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really good work here 🏆

.github/workflows/ci.yml

if [ -d "$TARGET_DIR" ]; then
for file in ${TARGET_DIR}gpx_*; do
if [ -f "$file" ] && [ ! -x "$file" ]; then
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sweeeet, didn't know about the -x flag 🏆

aangelisc
aangelisc approved these changes Mar 19, 2024
View reviewed changes
Copy link
Contributor

@aangelisc aangelisc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice work 😊

@adamyeats adamyeats merged commit 5f32592 into main Mar 19, 2024
5 checks passed
@adamyeats adamyeats deleted the playwright-e2e branch March 19, 2024 15:04
@adamyeats adamyeats mentioned this pull request Mar 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aangelisc aangelisc aangelisc approved these changes

@asimpson asimpson asimpson approved these changes

@bossinc bossinc Awaiting requested review from bossinc bossinc is a code owner automatically assigned from grafana/partner-datasources

@alyssabull alyssabull Awaiting requested review from alyssabull alyssabull is a code owner automatically assigned from grafana/partner-datasources

Assignees

@adamyeats adamyeats

Labels
datasource/SurrealDB enhancement New feature or request
Projects
Partner Datasources
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adamyeats @asimpson @aangelisc