-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: migrate to @grafana/llm package for OpenAI functionality #1052
base: main
Are you sure you want to change the base?
Conversation
Use the following command to run this PR with Docker at http://localhost:3000:
|
2ef0d07
to
8e51cb8
Compare
The @grafana/experimental package is being deprecated so development of LLM-related functionality has been moved to a separate package. The API is exactly the same so this _should_ just work. I've had to fix the resolution of some Grafana packages which were otherwise being duplicated because the @grafana/llm package has quite a loose dependency range; without this, we had both version 10.4.1 and 11.3.0 of the various Grafana packages (and all of their subdependencies) which was causing tests to fail. Fixes #1051.
8e51cb8
to
d9427ac
Compare
I've had to fix the resolution of some Grafana packages which were otherwise being duplicated because the @grafana/llm package has quite a loose dependency range; without this, we had both version 10.4.1 and 11.3.0 of the various Grafana packages (and all of their subdependencies) which was causing tests to fail. |
@sd2k, I'm not overly keen on adding in the resolutions. Can the dependencies for the LLM package be made stricter? Alternatively, we can look at updating the |
Yeah I'm not really keen on it either, I was surprised that the relaxed restrictions caused the resolver to choose two separate versions rather than preferring a common version 😕 Upgrading to 11+ would probably do the trick and feels like the right call, especially given those packages are injected by Grafana anyway. |
I think this is fine now that the correct versions are in the yarn.lock...
The @grafana/experimental package is being deprecated so development
of LLM-related functionality has been moved to a separate package.
The API is exactly the same so this should just work.
Fixes #1051.