Avoid using the pipe operator just once. #33

RudManusachi · 2019-05-01T08:58:38Z

I noticed using different styles in different parts
As stated in this style guide

# not preferred
some_string |> String.downcase()

# preferred
String.downcase(some_string)

now overall code formatting looks more consistent

(see Style Guide https://github.com/christopheradams/elixir_style_guide#avoid-single-pipelines) overall code formatting more consistent

shdblowers · 2019-10-09T13:34:08Z

I made a similar PR request to elixir-lang/elixir in the past and it got rejected, I think this one just comes down to personal preference.

RudolfMan · 2019-10-09T15:09:37Z

@shdblowers, hmm.. I just yesterday was looking into style guide and found this one which is approved by José Valim.

shdblowers · 2019-10-11T14:43:10Z

I guess the key word in his response is

mostly

Avoid using the pipe operator just once.

361287c

(see Style Guide https://github.com/christopheradams/elixir_style_guide#avoid-single-pipelines) overall code formatting more consistent

agenestar approved these changes Aug 2, 2019

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Avoid using the pipe operator just once. #33

Avoid using the pipe operator just once. #33

RudManusachi commented May 1, 2019

shdblowers commented Oct 9, 2019

RudolfMan commented Oct 9, 2019 •

edited

Loading

shdblowers commented Oct 11, 2019

Avoid using the pipe operator just once. #33

Are you sure you want to change the base?

Avoid using the pipe operator just once. #33

Conversation

RudManusachi commented May 1, 2019

shdblowers commented Oct 9, 2019

RudolfMan commented Oct 9, 2019 • edited Loading

shdblowers commented Oct 11, 2019

RudolfMan commented Oct 9, 2019 •

edited

Loading