Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(core): make header mark use underscore #1075

Merged
merged 3 commits into from
Jun 12, 2024
Merged

refactor(core): make header mark use underscore #1075

merged 3 commits into from
Jun 12, 2024

Conversation

etowahadams
Copy link
Contributor

Fix #1066
Toward #

Change List

  • Change "header" mark name to "_header" to clarify that it is only used internally.

Checklist

  • Ensure the PR works with all demos on the online editor
  • Unit tests added or updated
  • Examples added or updated
  • Documentation updated (e.g., added API functions)
  • Screenshots for visual changes (e.g., new encoding support or UI change on Editor)

@etowahadams etowahadams requested a review from sehilyi June 10, 2024 15:48
@sehilyi sehilyi merged commit eedb53b into main Jun 12, 2024
4 checks passed
@sehilyi sehilyi deleted the etowahadams/internal-header branch June 12, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sehilyi sehilyi sehilyi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clarify that the 'header' mark is only for internal usage (e.g., _header?)
2 participants
@etowahadams @sehilyi