Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): mouseEvent out of the experimental property #1072

Merged
merged 4 commits into from
Jun 12, 2024
Merged

feat(core): mouseEvent out of the experimental property #1072

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
842db94
feat: move mouseEvents out of experimental
etowahadams Jun 6, 2024
bdb59bf
fix: remove experimental from mouseEvents in goslingTrack
etowahadams Jun 6, 2024
6510a94
fix: change mouseEvent in spec
etowahadams Jun 6, 2024
706235a
feat: updated schema
etowahadams Jun 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 20 additions & 30 deletions editor/example/json-spec/mouse-event.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,11 +43,9 @@ export const EX_SPEC_MOUSE_EVENT: GoslingSpec = {
{
title: 'Individual Marks',
...BAR,
experimental: {
mouseEvents: {
mouseOver: true,
rangeSelect: true
}
mouseEvents: {
mouseOver: true,
rangeSelect: true
},
style: {
mouseOver: {
Expand All @@ -72,12 +70,10 @@ export const EX_SPEC_MOUSE_EVENT: GoslingSpec = {
{
title: 'Group Marks By Sample',
...BAR,
experimental: {
mouseEvents: {
mouseOver: true,
rangeSelect: true,
groupMarksByField: 'sample'
}
mouseEvents: {
mouseOver: true,
rangeSelect: true,
groupMarksByField: 'sample'
},
style: {
mouseOver: {
Expand All @@ -102,12 +98,10 @@ export const EX_SPEC_MOUSE_EVENT: GoslingSpec = {
{
title: 'Group Marks By Genomic Position',
...BAR,
experimental: {
mouseEvents: {
mouseOver: true,
rangeSelect: true,
groupMarksByField: 'position'
}
mouseEvents: {
mouseOver: true,
rangeSelect: true,
groupMarksByField: 'position'
},
style: {
mouseOver: {
Expand Down Expand Up @@ -167,12 +161,10 @@ export const EX_SPEC_MOUSE_EVENT: GoslingSpec = {
tooltip: [{ field: 'name', type: 'nominal' }],
width: BAR.width,
height: BAR.height,
experimental: {
mouseEvents: {
mouseOver: true,
rangeSelect: true,
groupMarksByField: 'name'
}
mouseEvents: {
mouseOver: true,
rangeSelect: true,
groupMarksByField: 'name'
},
style: {
mouseOver: {
Expand Down Expand Up @@ -200,13 +192,11 @@ export const EX_SPEC_MOUSE_EVENT: GoslingSpec = {
size: { value: 20 },
height: 60,
tooltip: [{ field: 'Chr.', type: 'nominal' }],
experimental: {
mouseEvents: {
click: true,
mouseOver: true,
rangeSelect: true,
groupMarksByField: 'Chr.'
}
mouseEvents: {
click: true,
mouseOver: true,
rangeSelect: true,
groupMarksByField: 'Chr.'
},
style: {
mouseOver: {
Expand Down
Loading
Loading