Skip to content

Commit

Permalink
feat(core): mouseEvent out of the experimental property (#1072)
Browse files Browse the repository at this point in the history
* feat: move mouseEvents out of experimental

* fix: remove experimental from mouseEvents in goslingTrack

* fix: change mouseEvent in spec

* feat: updated schema
  • Loading branch information
etowahadams authored Jun 12, 2024
1 parent eedb53b commit 1aa335b
Show file tree
Hide file tree
Showing 4 changed files with 191 additions and 201 deletions.
50 changes: 20 additions & 30 deletions editor/example/json-spec/mouse-event.ts
Original file line number Diff line number Diff line change
Expand Up @@ -43,11 +43,9 @@ export const EX_SPEC_MOUSE_EVENT: GoslingSpec = {
{
title: 'Individual Marks',
...BAR,
experimental: {
mouseEvents: {
mouseOver: true,
rangeSelect: true
}
mouseEvents: {
mouseOver: true,
rangeSelect: true
},
style: {
mouseOver: {
Expand All @@ -72,12 +70,10 @@ export const EX_SPEC_MOUSE_EVENT: GoslingSpec = {
{
title: 'Group Marks By Sample',
...BAR,
experimental: {
mouseEvents: {
mouseOver: true,
rangeSelect: true,
groupMarksByField: 'sample'
}
mouseEvents: {
mouseOver: true,
rangeSelect: true,
groupMarksByField: 'sample'
},
style: {
mouseOver: {
Expand All @@ -102,12 +98,10 @@ export const EX_SPEC_MOUSE_EVENT: GoslingSpec = {
{
title: 'Group Marks By Genomic Position',
...BAR,
experimental: {
mouseEvents: {
mouseOver: true,
rangeSelect: true,
groupMarksByField: 'position'
}
mouseEvents: {
mouseOver: true,
rangeSelect: true,
groupMarksByField: 'position'
},
style: {
mouseOver: {
Expand Down Expand Up @@ -167,12 +161,10 @@ export const EX_SPEC_MOUSE_EVENT: GoslingSpec = {
tooltip: [{ field: 'name', type: 'nominal' }],
width: BAR.width,
height: BAR.height,
experimental: {
mouseEvents: {
mouseOver: true,
rangeSelect: true,
groupMarksByField: 'name'
}
mouseEvents: {
mouseOver: true,
rangeSelect: true,
groupMarksByField: 'name'
},
style: {
mouseOver: {
Expand Down Expand Up @@ -200,13 +192,11 @@ export const EX_SPEC_MOUSE_EVENT: GoslingSpec = {
size: { value: 20 },
height: 60,
tooltip: [{ field: 'Chr.', type: 'nominal' }],
experimental: {
mouseEvents: {
click: true,
mouseOver: true,
rangeSelect: true,
groupMarksByField: 'Chr.'
}
mouseEvents: {
click: true,
mouseOver: true,
rangeSelect: true,
groupMarksByField: 'Chr.'
},
style: {
mouseOver: {
Expand Down
Loading

0 comments on commit 1aa335b

Please sign in to comment.