fix: fix not add continue on parse branch line error

gookit · Jun 29, 2022 · 77e6932 · 77e6932
1 parent 011dc24
commit 77e6932
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 0 deletions.
diff --git a/info_branch.go b/info_branch.go
@@ -113,6 +113,7 @@ func (bs *BranchInfos) Parse() *BranchInfos {
 		info, err := ParseBranchLine(line, verbose)
 		if err != nil {
 			bs.err = err
+			continue
 		}
 
 		// collect

diff --git a/info_test.go b/info_test.go
@@ -111,6 +111,23 @@ func TestBranchInfo_parse_simple(t *testing.T) {
 	assert.Equal(t, "master", bis.Current().Name)
 }
 
+func TestBranchInfo_parse_invalid(t *testing.T) {
+	gitOut := `
+  fea/new_br001
+* (HEAD)
+  my_new_br 
+  remotes/origin/my_new_br 
+`
+	bis := gitw.NewBranchInfos(gitOut)
+	bis.Parse()
+	// dump.P(bis)
+
+	assert.Error(t, bis.LastErr())
+	assert.Nil(t, bis.Current())
+	assert.NotEmpty(t, bis.Locales())
+	assert.NotEmpty(t, bis.Remotes("origin"))
+}
+
 func TestBranchInfo_parse_verbose(t *testing.T) {
 	gitOut := `
   fea/new_br001              73j824d the message 001