chore: Release Please anontations for dependencies.properties #3396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes googleapis#2428 The libraries released from api-common-java, java-common-protos, and java-iam are annotated in gax-java/dependencies.properties. These annotations allows the version values updated at the time of the release pull request, ensuring the generated Gradle files to have a proper dependency set.
JoeWang1127
approved these changes
Nov 25, 2024
lqiu96
pushed a commit
to lqiu96/gapic-generator-java
that referenced
this pull request
Nov 25, 2024
…apis#3396) Fixes googleapis#2428 The libraries released from api-common-java, java-common-protos, and java-iam are annotated in gax-java/dependencies.properties. These annotations allows the version values updated at the time of the release pull request, ensuring the generated Gradle files to have a proper dependency set.
suztomo
added a commit
that referenced
this pull request
Nov 26, 2024
…es (#3398) Reverts #3396 #3382 (comment) > I think my pull request about Release Please annotation broke the CI checks for Release Please pull request. The Bazel integration tests are not ready to use the locally installed artifacts in local Maven repository. GAX artifacts are fine because they are from Bazel package. I'll need to explore how to build them in c8cb5ae#diff-8a0414289f48984fdac9f835e30a3c10f79ebef40088b9045c98665d2bddb6e3.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2428
The libraries released from api-common-java, java-common-protos, and java-iam are annotated in gax-java/dependencies.properties. These annotations allows the version values updated at the time of the release pull request, ensuring the generated Gradle files to have a proper dependency set.