fix: plumb mtlsEndpoint to gRPC Channel provider instead of setting it in EndpointContext. #3386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
rmehta19
force-pushed
the
directpath-endpoint-fix
branch
from
364ea86
to
0f517a9
Compare
rmehta19
commented
Nov 19, 2024
| @@ -272,10 +272,6 @@ private String determineUniverseDomain() { | |||
|
|
|||
| /** Determines the fully resolved endpoint and universe domain values */ | |||
| private String determineEndpoint() throws IOException { | |||
| if (shouldUseS2A()) { | |||
There was a problem hiding this comment.
WDYT of renaming this to canUseS2A(), since that's what the result of this function is really indicating.
For example, it is possible that this function returns true and canUseDirectPath in InstantiatingGrpcChannelProvider` returns true, and we therefore end up not using S2A.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a problem where if DirectPath is to be used (
canUseDirectPathis going to return true), but endpoint resolution determines conditions are met to use S2A, the endpoint incorrectly gets set to mtls endpoint.We only try S2A logic (e.g we only look at
useS2A), if we have ruled out DirectPath as an option (canUseDirectPathI()returns false), but endpoint resolution logic doesn't know this, and will set endpoint to mtls endpoint if it determines S2A can be used, even if DirectPath can be used.