Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove maven latest version #3383

Merged
merged 6 commits into from
Nov 19, 2024
Merged

Conversation

JoeWang1127
Copy link
Collaborator

@JoeWang1127 JoeWang1127 commented Nov 19, 2024

In this PR:

  • Remove functions to get latest library version from Maven Central

@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Nov 19, 2024
@@ -1,5 +1,4 @@
gapic_generator_version: 2.38.1
protoc_version: 25.2
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to remove protoc_version, otherwise running the image will download a different version of protoc than the baked in version (25.5).

@JoeWang1127 JoeWang1127 marked this pull request as ready for review November 19, 2024 17:26
Copy link

sonarcloud bot commented Nov 19, 2024

Copy link

sonarcloud bot commented Nov 19, 2024

Quality Gate Passed Quality Gate passed for 'java_showcase_integration_tests'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@JoeWang1127 JoeWang1127 merged commit ac9605b into main Nov 19, 2024
48 of 55 checks passed
@JoeWang1127 JoeWang1127 deleted the chore/remove-mvn-latest-ver branch November 19, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants