Skip to content

Commit

Permalink
[ggj][engx] fix: update IAMCredentialsTest name handling (#605)
Browse files Browse the repository at this point in the history
* fix: fix dep ordering in Bazel dedupe rules

* chore:  centralize all Gapic class name getters

* fix: use gapic-remapped names in package-info.java

* fix: revert unrelated changes

* fix: handle back-compat casing for IAMCredentials API

* fix: update IAMCredentialsTest name handling
  • Loading branch information
miraleung authored Dec 16, 2020
1 parent 6c06c55 commit ca68fbe
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -64,9 +64,7 @@ protected static String getGrpcServiceStubClassName(Service service) {
}

protected static String getServiceClientTestClassName(Service service) {
return String.format(
SERVICE_CLIENT_TEST_CLASS_NAME_PATTERN,
monolithBackwardsCompatibleName(service.overriddenName()));
return String.format(SERVICE_CLIENT_TEST_CLASS_NAME_PATTERN, service.overriddenName());
}

protected static String getMockServiceClassName(Service service) {
Expand Down
3 changes: 2 additions & 1 deletion test/integration/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,8 @@ java_gapic_library(
java_gapic_test(
name = "credentials_java_gapic_test_suite",
test_classes = [
"com.google.cloud.iam.credentials.v1.IamCredentialsClientTest",
# Match google3.
"com.google.cloud.iam.credentials.v1.IAMCredentialsClientTest",
],
runtime_deps = [":credentials_java_gapic_test"],
)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@
import org.junit.Test;

@Generated("by gapic-generator-java")
public class IamCredentialsClientTest {
public class IAMCredentialsClientTest {
private static MockServiceHelper mockServiceHelper;
private static MockIAMCredentials mockIAMCredentials;
private IamCredentialsClient client;
Expand Down

0 comments on commit ca68fbe

Please sign in to comment.