Skip to content

Commit

Permalink
rephrase after code review
Browse files Browse the repository at this point in the history
  • Loading branch information
JoeWang1127 committed Nov 20, 2024
1 parent 923d3a6 commit c7a90e4
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
8 changes: 4 additions & 4 deletions hermetic_build/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -44,9 +44,9 @@ for more information.
The default value is `$(pwd)/generation_config.yaml`, i.e., `generation_config.yaml`
in the current working directory.

Raise `FileNotFoundError` if the specified generation config does not exist or,
in the case `generation-config-path` is not specified, the default generation
config does not exist.
This will raise `FileNotFoundError` if the specified generation config does not
exist or, in case `generation-config-path` is not specified, the default
generation config does not exist.

### Repository path (`repository-path`), optional

Expand All @@ -58,7 +58,7 @@ specifying the `--repository_path` option will modify the `google-cloud-java`
repository the user `cd`'d into.

Note that `versions.txt` has to exist in `repository_path` in order to generate
right version for each library.
the right version for each library.
Please refer [here](go/java-client-releasing#versionstxt-manifest) for more info
of versions.txt.

Expand Down
2 changes: 1 addition & 1 deletion hermetic_build/library_generation/cli/entry_point.py
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ def generate(
generation config will be generated.
:raise FileNotFoundError if the specified generation config does not exist
or, in the case `generation-config-path` is not specified, the default
or, in case `generation-config-path` is not specified, the default
generation config does not exist.
"""
__generate_repo_impl(
Expand Down

0 comments on commit c7a90e4

Please sign in to comment.