[pointer][transmute] Migrate from util #1911
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 15, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1911 +/- ##
=======================================
Coverage 89.46% 89.46%
=======================================
Files 16 17 +1
Lines 5838 5838
=======================================
Hits 5223 5223
Misses 615 615 ☔ View full report in Codecov by Sentry. |
This was referenced Oct 15, 2024
jswrenn
approved these changes
Oct 15, 2024
joshlf
force-pushed
the
Ifc49755af0d90eeefe7822d755d508403c266bda
branch
3 times, most recently
from
c3a2206
to
7643459
Compare
joshlf
changed the base branch from
main
to
I3a111bf5647fdcc9805cbadf36f729ac69b28509
Base automatically changed from
I3a111bf5647fdcc9805cbadf36f729ac69b28509
to
main
October 17, 2024 02:42
joshlf
changed the base branch from
main
to
I3a111bf5647fdcc9805cbadf36f729ac69b28509
Base automatically changed from
I3a111bf5647fdcc9805cbadf36f729ac69b28509
to
main
October 17, 2024 15:14
joshlf
force-pushed
the
Ifc49755af0d90eeefe7822d755d508403c266bda
branch
2 times, most recently
from
b36cb1c
to
4bd33fb
Compare
joshlf
force-pushed
the
Ifc49755af0d90eeefe7822d755d508403c266bda
branch
2 times, most recently
from
03ccfe5
to
244bef4
Compare
This was referenced Oct 22, 2024
joshlf
force-pushed
the
Ifc49755af0d90eeefe7822d755d508403c266bda
branch
from
244bef4
to
5f1d243
Compare
This was referenced Oct 23, 2024
joshlf
force-pushed
the
Ifc49755af0d90eeefe7822d755d508403c266bda
branch
from
5f1d243
to
995e1f0
Compare
This prepares us to rename `TransparentWrapper` to `TransmuteFrom`, which we'll do in a follow-up commit to preserve nice git diffs. Makes progress on #1122 gherrit-pr-id: Ifc49755af0d90eeefe7822d755d508403c266bda
joshlf
force-pushed
the
Ifc49755af0d90eeefe7822d755d508403c266bda
branch
from
995e1f0
to
4f292ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prepares us to rename
TransparentWrappertoTransmuteFrom,which we'll do in a follow-up commit to preserve nice git diffs.
Makes progress on #1122
This PR is on branch ptr-overhaul-more-generic-issue-1945.