[cleanup] Get rid of need for external/ on z3 library includes #1740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdleary
force-pushed
the
cdleary/2024-11-21-get-rid-of-z3-extern
branch
from
6a3b468
to
5bacb25
Compare
cdleary
had a problem deploying
to
github-pages
GitHub Actions
Failure
meheff
approved these changes
Nov 21, 2024
|
Given that we want to use MODULE.bazel at some point, I think I'd avoid patching external cc_library() targets to avoid too much local modifications. But I am wondering if I can convince the external Verible maintainer to work on a weekend hack to move everything down a directory in the upstream project: |
|
I had a talk with the Verible maintainer ( 😃 ) and he agreed to put everything under a subdirectory upstream on the weekend. |
cdleary
had a problem deploying
to
github-pages
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #1736
For verible we can probably patch the cc_library targets we depend on to add the include_prefix attribute similarly.