Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add one config_yaml entry to google/fonts for testing #8683

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

rsheeter
Copy link
Collaborator

@rsheeter rsheeter commented Dec 1, 2024

As per googlefonts/fontc#1124. gftools needs a release to understand this.

Copy link

github-actions bot commented Dec 1, 2024

FontBakery report

fontbakery version: 0.13.0a5

Checks with FATAL results

These must be addressed first.

[1] RubikPixels-Regular.ttf
FATAL Check METADATA.pb parse correctly.
  • FATAL

    Family metadata at ofl/rubikpixels failed to parse.
    TRACEBACK:
    24:3 : Message type "google.fonts_public.SourceProto" has no field named "config_yaml".


    [code: parsing-error]

All other checks

[24] RubikPixels-Regular.ttf
🔥 FAIL Check for codepoints not covered by METADATA subsets.
  • 🔥 FAIL

    Could not parse metadata.pb file


    [code: unparsable-metadata]
🔥 FAIL Shapes languages in all GF glyphsets.
  • 🔥 FAIL

    GF_Phonetics_SinoExt glyphset:

FAIL messages Languages
Some base glyphs were missing: ẞ de_Latn (German)
[code: failed-language-shaping]
  • ⚠️ WARN

    GF_Phonetics_SinoExt glyphset:

WARN messages Languages
Some auxiliary glyphs were missing: Ʒ, Ǥ, ǥ, Ǯ, ǯ, ʒ, ẞ fi_Latn (Finnish)
Some auxiliary glyphs were missing: ẞ fr_Latn (French), it_Latn (Italian), pl_Latn (Polish) and tr_Latn (Turkish)
[code: warning-language-shaping]
🔥 FAIL Check Google Fonts glyph coverage.
  • 🔥 FAIL

    Missing required codepoints:

- 0x1E9E (LATIN CAPITAL LETTER SHARP S)

[code: missing-codepoints]

⚠️ WARN Check if each glyph has the recommended amount of contours.
  • ⚠️ WARN

    This check inspects the glyph outlines and detects the total number of contours in each of them. The expected values are infered from the typical ammounts of contours observed in a large collection of reference font families. The divergences listed below may simply indicate a significantly different design on some of your glyphs. On the other hand, some of these may flag actual bugs in the font such as glyphs mapped to an incorrect codepoint. Please consider reviewing the design and codepoint assignment of these to make sure they are correct.

The following glyphs do not have the recommended number of contours:

- Glyph name: exclam	Contours detected: 757	Expected: 2
  • Glyph name: quotedbl Contours detected: 494 Expected: 2

  • Glyph name: numbersign Contours detected: 1312 Expected: 2

  • Glyph name: dollar Contours detected: 1865 Expected: 1, 3 or 5

  • Glyph name: percent Contours detected: 1490 Expected: 4 or 5

  • Glyph name: ampersand Contours detected: 1672 Expected: 1, 2 or 3

  • Glyph name: quotesingle Contours detected: 272 Expected: 1

  • Glyph name: parenleft Contours detected: 991 Expected: 1

  • Glyph name: parenright Contours detected: 780 Expected: 1

  • Glyph name: asterisk Contours detected: 491 Expected: 1 or 4

  • 1174 more.

Use -F or --full-lists to disable shortening of long lists.

[code: contour-count]
⚠️ WARN Ensure files are not too large.
  • ⚠️ WARN

    Font file is 5.4Mb; ideally it should be less than 1.0Mb


    [code: large-font]
⚠️ WARN Is there kerning info for non-ligated sequences?
  • ⚠️ WARN

    GPOS table lacks kerning info for the following non-ligated sequences:

- f + f

- f + i

- f + l

[code: lacks-kern-info]

⚠️ WARN Check math signs have the same width.
  • ⚠️ WARN

    The most common width is 538 among a set of 2 math glyphs.
    The following math glyphs have a different width, though:

Width = 594: plus

Width = 563: equal

Width = 564: logicalnot

Width = 576: plusminus

Width = 639: multiply

Width = 517: divide

Width = 642: minus

Width = 551: notequal, approxequal

Width = 556: lessequal, greaterequal

[code: width-outliers]
⚠️ WARN Check there are no overlapping path segments
  • ⚠️ WARN

    The following glyphs have overlapping path segments:

* Oslash (U+00D8): L<<195.0,74.0>--<195.0,70.0>> has the same coordinates as a previous segment.

* Oslash (U+00D8): L<<165.0,74.0>--<165.0,70.0>> has the same coordinates as a previous segment.

* Oslash (U+00D8): L<<175.0,74.0>--<175.0,70.0>> has the same coordinates as a previous segment.

* Oslash (U+00D8): L<<185.0,74.0>--<185.0,70.0>> has the same coordinates as a previous segment.

* Oslash (U+00D8): L<<190.0,69.0>--<190.0,65.0>> has the same coordinates as a previous segment.

* Oslash (U+00D8): L<<180.0,69.0>--<180.0,65.0>> has the same coordinates as a previous segment.

* Oslash (U+00D8): L<<175.0,64.0>--<175.0,60.0>> has the same coordinates as a previous segment.

* Oslash (U+00D8): L<<195.0,64.0>--<195.0,60.0>> has the same coordinates as a previous segment.

* Oslash (U+00D8): L<<185.0,64.0>--<185.0,60.0>> has the same coordinates as a previous segment.

* Oslash (U+00D8): L<<180.0,59.0>--<180.0,55.0>> has the same coordinates as a previous segment.

* 640 more.

Use -F or --full-lists to disable shortening of long lists.

[code: overlapping-path-segments]
⚠️ WARN Does the font contain a soft hyphen?
  • ⚠️ WARN

    This font has a 'Soft Hyphen' character.


    [code: softhyphen]
⚠️ WARN Check font contains no unreachable glyphs
  • ⚠️ WARN

    The following glyphs could not be reached by codepoint or substitution rules:

- pixel4

[code: unreachable-glyphs]

⚠️ WARN Validate size, and resolution of article images, and ensure article page has minimum length and includes visual assets.
  • ⚠️ WARN

    Family metadata at ofl/rubikpixels does not have an article.


    [code: lacks-article]
⚠️ WARN On a family update, the DESCRIPTION.en_us.html file should ideally also be updated.
  • ⚠️ WARN

    The DESCRIPTION.en_us.html file in this family has not changed in comparison to the latest font release on the google/fonts github repo.
    Please consider mentioning note-worthy improvements made to the family recently.


    [code: description-not-updated]
⚠️ WARN Check copyright namerecords match license file.
⚠️ WARN Ensure dotted circle glyph is present and can attach marks.
  • ⚠️ WARN

    No dotted circle glyph present


    [code: missing-dotted-circle]
⚠️ WARN Ensure soft_dotted characters lose their dot when combined with marks that replace the dot.
  • ⚠️ WARN

    The dot of soft dotted characters used in orthographies must disappear in the following strings: į̀ į́ į̂ į̃ į̄ į̌ і́

The dot of soft dotted characters should disappear in other cases, for example: i̦̒ j̦̒ į̆ į̇ į̈ į̊ į̋ į̒ į̦̒ į̧̒ į̨̒ į̵̀ į̵́ į̵̂ į̵̃ į̵̄ į̵̆ į̵̇ į̵̈ į̵̊

Your font fully covers the following languages that require the soft-dotted feature: Lithuanian (Latn, 2,357,094 speakers), Dutch (Latn, 31,709,104 speakers), Ukrainian (Cyrl, 29,273,587 speakers), Belarusian (Cyrl, 10,064,517 speakers).

Your font does not cover the following languages that require the soft-dotted feature: South Central Banda (Latn, 244,000 speakers), Makaa (Latn, 221,000 speakers), Ekpeye (Latn, 226,000 speakers), Dan (Latn, 1,099,244 speakers), Southern Tutchone (Latn, 65 speakers), Bafut (Latn, 158,146 speakers), Ebira (Latn, 2,200,000 speakers), Keliko (Latn, 63,000 speakers), Mfumte (Latn, 79,000 speakers), Ejagham (Latn, 120,000 speakers), Vute (Latn, 21,000 speakers), Nzakara (Latn, 50,000 speakers), Teke-Ebo (Latn, 260,000 speakers), Gulay (Latn, 250,478 speakers), Abua (Latn, 25,000 speakers), Navajo (Latn, 166,319 speakers), Cicipu (Latn, 44,000 speakers), Aghem (Latn, 38,843 speakers), Basaa (Latn, 332,940 speakers), Kom (Latn, 360,685 speakers), Ngbaka (Latn, 1,020,000 speakers), Ijo, Southeast (Latn, 2,471,000 speakers), Igbo (Latn, 27,823,640 speakers), Longto (Latn, 5,000 speakers), Avokaya (Latn, 100,000 speakers), Zapotec (Latn, 490,000 speakers), Nateni (Latn, 100,000 speakers), Kaska (Latn, 125 speakers), Lugbara (Latn, 2,200,000 speakers), Southern Kisi (Latn, 360,000 speakers), Bete-Bendi (Latn, 100,000 speakers), Han (Latn, 6 speakers), Kpelle, Guinea (Latn, 622,000 speakers), Western Krahn (Latn, 97,800 speakers), Mundani (Latn, 34,000 speakers), Ma’di (Latn, 584,000 speakers), Heiltsuk (Latn, 300 speakers), Fur (Latn, 1,230,163 speakers), Koonzime (Latn, 40,000 speakers), Dii (Latn, 71,000 speakers), Yala (Latn, 200,000 speakers), Northern Tutchone (Latn, 85 speakers), Ikwere (Latn, 717,000 speakers), Mango (Latn, 77,000 speakers), Sar (Latn, 500,000 speakers).

[code: soft-dotted]
⚠️ WARN Ensure fonts have ScriptLangTags declared on the 'meta' table.
  • ⚠️ WARN

    This font file does not have a 'meta' table.


    [code: lacks-meta-table]
ℹ️ INFO List all superfamily filepaths
  • ℹ️ INFO

    ofl/rubikpixels


    [code: family-path]
ℹ️ INFO EPAR table present in font?
ℹ️ INFO Show hinting filesize impact.
  • ℹ️ INFO

    Hinting filesize impact:

ofl/rubikpixels/RubikPixels-Regular.ttf
Dehinted Size 5.4Mb
Hinted Size 5.4Mb
Increase 24 bytes
Change 0.0 %
[code: size-impact]
ℹ️ INFO Font contains all required tables?
  • ℹ️ INFO

    This font contains the following optional tables:

- loca

- prep

- GPOS

- GSUB

- gasp

[code: optional-tables]

ℹ️ INFO Does DESCRIPTION file contain a upstream Git repo URL?
ℹ️ INFO Check for presence of an ARTICLE.en_us.html file
  • ℹ️ INFO

    This font doesn't have an ARTICLE.en_us.html file.


    [code: missing-article]
ℹ️ INFO Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering?
  • ℹ️ INFO

    These are the ppm ranges declared on the gasp table:

PPM <= 65535: flag = 0x0F - Use grid-fitting - Use grayscale rendering - Use gridfitting with ClearType symmetric smoothing - Use smoothing along multiple axes with ClearType®

[code: ranges]
ℹ️ INFO Font has old ttfautohint applied?
  • ℹ️ INFO

    Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: ['Version 2.200']


    [code: version-not-detected]
[1] Family checks
ℹ️ INFO Check axis ordering on the STAT table.
  • ℹ️ INFO

    All of the fonts lack a STAT table.


    [code: summary]

Summary

💥 ERROR ☠ FATAL 🔥 FAIL ⚠️ WARN ⏩ SKIP ℹ️ INFO ✅ PASS 🔎 DEBUG
0 1 3 13 106 9 120 0
0% 0% 1% 5% 42% 4% 48% 0%

Note: The following loglevels were omitted in this report:

  • SKIP
  • PASS
  • DEBUG

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant