Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: conditional cstdio include in vk_mem_alloc #8265

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

@pixelflinger pixelflinger added the internal Issue/PR does not affect clients label Nov 11, 2024
@poweifeng
Copy link
Contributor

Is this meant to reduce the size of the lib?

@aminya
Copy link
Author

aminya commented Nov 12, 2024

Is this meant to reduce the size of the lib?

It's something I noticed when I was comparing the upstream code vs the vendored third party. It's mostly for consistency, but it could benefit the lib size.

https://github.com/GPUOpen-LibrariesAndSDKs/VulkanMemoryAllocator/blob/05973d8aeb1a4d12f59aadfb86d20decadba82d1/include/vk_mem_alloc.h#L2842

@poweifeng
Copy link
Contributor

Is this meant to reduce the size of the lib?

It's something I noticed when I was comparing the upstream code vs the vendored third party. It's mostly for consistency, but it could benefit the lib size.

https://github.com/GPUOpen-LibrariesAndSDKs/VulkanMemoryAllocator/blob/05973d8aeb1a4d12f59aadfb86d20decadba82d1/include/vk_mem_alloc.h#L2842

I think the proper way to address this is actually to update our third_party vendor lib.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Issue/PR does not affect clients
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants