Scx1332/trying to run2 #31
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… sometimes not) which resulted in mismatched hash in services.
…ory/ya-runtime-http-auth into scx1332/trying_to_run2
This reverts commit 93cb7c2.
prekucki
reviewed
Nov 2, 2022
| @@ -72,3 +72,18 @@ impl Display for Addresses { | |||
| write!(f, "]") | |||
| } | |||
| } | |||
|
|
|||
| impl Addresses { | |||
| pub fn gather_and_sort_addresses( | |||
There was a problem hiding this comment.
this is a very bad coding style.
-
Why associated function?
addr::Addresss:: gather_and_sort_addresses(...)looks better than simpleaddr::gather_and_sort_addresses. -
Why this is a public API for address?
this is a very specific name gather and sort. it does not look like something general to be done on adresses.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.