implement client trace metrics #12
Conversation
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| @@ -44,3 +46,91 @@ func Metrics(config *metrics.Config) httpware.Tripperware { | |||
| }) | |||
| } | |||
| } | |||
|
|
|||
| func MetricsTrace(it *metrics.InstrumentTrace) httpware.Tripperware { | |||
There was a problem hiding this comment.
Function MetricsTrace has 83 lines of code (exceeds 50 allowed). Consider refactoring.
| @@ -44,3 +46,91 @@ func Metrics(config *metrics.Config) httpware.Tripperware { | |||
| }) | |||
| } | |||
| } | |||
|
|
|||
| func MetricsTrace(it *metrics.InstrumentTrace) httpware.Tripperware { | |||
There was a problem hiding this comment.
Function MetricsTrace has a Cognitive Complexity of 64 (exceeds 20 allowed). Consider refactoring.
| "github.com/gol4ng/httpware/metrics" | ||
| ) | ||
|
|
||
| func NewInstrumentTrace(config ConfigTrace) *metrics.InstrumentTrace { |
There was a problem hiding this comment.
Function NewInstrumentTrace has 72 lines of code (exceeds 50 allowed). Consider refactoring.
| TLSLatencyBuckets []float64 | ||
| } | ||
|
|
||
| func (c *ConfigTrace) defaults() { |
There was a problem hiding this comment.
U1000: func (*ConfigTrace).defaults is unused (from unused)
|
Code Climate has analyzed commit caf4f94 and detected 3 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 0.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 70.7% (-29.3% change). View more on Code Climate. |
WIP enhance conf/metrics builder
TODO write tests