Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the navigation process #20772

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

AllForNothing
Copy link
Contributor

1.Fixes #19630
2.Allow unauthenticated users to view public projects's detail page and its public tabs
image

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Copy link

codecov bot commented Jul 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.25%. Comparing base (c8c11b4) to head (a915961).
Report is 319 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #20772       +/-   ##
===========================================
+ Coverage   45.36%   66.25%   +20.88%     
===========================================
  Files         244     1045      +801     
  Lines       13333   113478   +100145     
  Branches     2719     2835      +116     
===========================================
+ Hits         6049    75180    +69131     
- Misses       6983    34187    +27204     
- Partials      301     4111     +3810     
Flag Coverage Δ
unittests 66.25% <ø> (+20.88%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1287 files with indirect coverage changes

1.Fixes goharbor#19630
2.Allow unauthenticated users to view public projects's detail page and
its public tabs

Signed-off-by: Shijun Sun <373492212@qq.com>
@wy65701436
Copy link
Contributor

@zyyw could you please have a validation?

Copy link

github-actions bot commented Oct 1, 2024

This PR is being marked stale due to a period of inactivty. If this PR is still relevant, please comment or remove the stale label. Otherwise, this PR will close in 30 days.

@github-actions github-actions bot added the Stale label Oct 1, 2024
@Vad1mo Vad1mo removed the Stale label Oct 1, 2024
@wy65701436 wy65701436 added target/2.13.0 issues that are targeting v2.13.0 and removed target/2.12.0 labels Oct 24, 2024
@wy65701436 wy65701436 added candidate/2.13.0 and removed target/2.13.0 issues that are targeting v2.13.0 labels Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Guest navigation on public projects
5 participants