Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate UseMiddlewarWithContainer and remove it from tests and docs #1228

Merged
merged 4 commits into from
Nov 25, 2024

Conversation

Umang01-hash
Copy link
Contributor

@Umang01-hash Umang01-hash commented Nov 20, 2024

Pull Request Template

Description:

  • Deprecate feature UseMiddlewareWithContainer.

Reason for Deprecation:

We are deprecating the UseMiddlewareWithContainer feature due to architectural considerations. Allowing middleware to access databases or caches introduces unnecessary complexities.

By removing this support, we aim to encourage a cleaner separation of concerns, ensuring that middleware remains focused on its intended purpose. This change will help in maintaining the simplicity and integrity of our framework.

Checklist:

  • I have formatted my code using goimport and golangci-lint.
  • All new code is covered by unit tests.
  • This PR does not decrease the overall code coverage.
  • I have reviewed the code comments and documentation for clarity.

Thank you for your contribution!

pkg/gofr/gofr_test.go Outdated Show resolved Hide resolved
pkg/gofr/gofr.go Outdated Show resolved Hide resolved
@vikash vikash merged commit 15e0f6b into development Nov 25, 2024
12 checks passed
@vikash vikash deleted the deprecate-useMiddlewareWithContainer branch November 25, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants