Implement XL_PLATFORM for Unix #198
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XL_PLATFORM for windows was implemented via a seperate PR at goatcorp/FFXIVQuickLauncher#1648. XoM uses their own fork of XLCommon that isn't the one in this repository, so it's fine to assume its only Linux here I think, I don't know anyone using this on a Mac
reiichi001
previously approved these changes
Nov 28, 2024
Blooym
dismissed
reiichi001’s stale review
The merge-base changed after approval.
|
Users can technically run xlcore on windows. Does that impact that? (Or is it only a case of updating the submodule later?) |
|
Would only need to update the submodule once the PR on that side is merged, will have the same logic |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requested at #77 for Dalamud here https://github.com/goatcorp/Dalamud/blob/f16a3367c0fad56b4ce760439823122fc6845580/Dalamud/Utility/Util.cs#L527-L534
XL_PLATFORM was also implemented via a seperate PR at goatcorp/FFXIVQuickLauncher#1648 mainly for Windows, but also for XoM (I think it pulls from there for some stuff).
This just duplicates the work here for the Unix side. The windows stuff will need a submodule update if its ever merged.