-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add YubiKey authentication functionality #1378
base: master
Are you sure you want to change the base?
Conversation
Peanut gallery commentary (and not something necessary for this PR): This would be a great opportunity to implement some kind of authentication plugin logic to XL so that people can load in all sorts of custom behavior (e.g. this, 1Password, the TOTP webserver, highly insecure homebaked DLLs with hardcoded TOTP secrets, etc.) that can provide credentials or TOTP to XL. Otherwise, this is a very interesting PR and an awesome new feature. Thanks for making it!! |
+1 for that idea @KazWolfe mentioned (but neither of us are XL team so don't take it as official word). Perhaps just exchanging messages over stdin/stdout in an executable you can configure sounds good. |
And an actual comment: At present, this does not appear to support multiple accounts. Would it be possible to tweak the behavior slightly to encode the SE username into the credential so that we can gracefully handle multi-service-account cases? |
Thanks for the feedback! Yes this is possible and I've gone ahead and tweaked the implementation so that this could happen. |
Adds ability to use a YubiKey security key to generate OTP codes and use them to login.
Please also consider this corresponding pull request on the faq repo: #89
Additions:
SettingsControl
YubiAuth
OtpInputDialog
SecurityKeySetupDialog
Directory.Build.targets