Dev4 #26
Merged
Dev4 #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e deps,healthchecks
…lhost:<port> to :<port>, replaced string servers params with env variables
…rod.yml for pulling images while deploying
…nsible, add inventory in .gitignore
…board, search, subscription
TP-6ec_easyjson: generated easyjson, changed serialization for user, …
Tp c01 ci cd
TP-6ec_easyjson: add rest easyjson
…d auth config to main.go
…_2_OND_team' folder to dest
Tp 87a filtration
Yakwilik
reviewed
Dec 20, 2023
.github/workflows/ci.yml
Outdated
| push: {} | ||
| pull_request: | ||
| types: [opened, edited, reopened] | ||
| branches: [main, dev4] |
There was a problem hiding this comment.
может сделать для любой ветки dev? или вам только в этих двух ветках пайплайн с тестами нужен?
There was a problem hiding this comment.
добавили остальные ветки
Yakwilik
reviewed
Dec 20, 2023
Makefile
Outdated
|
|
||
| ENTRYPOINT=cmd/app/main.go | ||
| DOC_DIR=./docs | ||
| COV_OUT=coverage.out | ||
| COV_HTML=coverage.html | ||
| CURRCOVER=github.com/go-park-mail-ru/2023_2_OND_team/internal/pkg/delivery/http/v1 | ||
|
|
||
| PROJECT_DIR = $(shell pwd) |
There was a problem hiding this comment.
У make есть такая переменная $(CURDIR)
Yakwilik
reviewed
Dec 20, 2023
| @@ -56,8 +56,8 @@ func (h *HandlerHTTP) CheckLogin(w http.ResponseWriter, r *http.Request) { | |||
| func (h *HandlerHTTP) Login(w http.ResponseWriter, r *http.Request) { | |||
| logger := h.getRequestLogger(r) | |||
|
|
|||
| params := usecase.UserCredentials{} | |||
| err := json.NewDecoder(r.Body).Decode(¶ms) | |||
There was a problem hiding this comment.
если для структуры определены методы декода, то они тут будут использоваться вместо дефолтных, так что можно было не менять
Yakwilik
approved these changes
Dec 20, 2023
Andeo1812
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.