Skip to content
This repository has been archived by the owner on Oct 6, 2020. It is now read-only.

Adding a debugger message when no errors and cache is hit #7

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Adding a debugger message when no errors and cache is hit #7

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6a6d9ad
Adding a debugger message when no errors and cache is hit
Jun 7, 2016
40f85e3
Cache hit debug message now contains request url
Jun 8, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,7 @@ HttpCache.prototype = {
return self._makeRequest(requestUrl, options, key, null, requestStartTime, callback, next);
}

debug('All working fine, cache hit');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea!

Would you be able to change the debug message to ...

debug('Cache hit for %s', requestUrl);

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure!

self.stats.increment(['hit', 'hit.fresh']);

if (cachedContent.backendResponseTime) {
Expand Down