This repository has been archived by the owner on Oct 6, 2020. It is now read-only.
Fix issues when the initial (cached) request is json #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 8, 2016 16:37
If subsequent requests want json output (options.json = true), then we try to JSON.parse() the cached content, which is already json, which throws. This causes the cache lookup to fail, so we go get from source again. If subsequent requests don't want json output, then we successfully serve from the cache, but the cached content is json, rather than the expected string content.
We JSON.parse and JSON.stringify the cached results as necessary.
| var parsed = JSON.parse(cachedContent.body); | ||
| var parsed; | ||
| if( typeof cachedContent.body === 'object' ) { | ||
| parsed = cachedContent.body; |
There was a problem hiding this comment.
This needs to return a deep clone, otherwise client changes to the object would bleed between requests.
added 3 commits
March 9, 2016 09:44
Previously, if any request handler modified a json response, then that modification would remain in the cache and be incorrectly returned in subsequent requests. With this change, we deep clone cached objects so each request handler gets its own copy of the original response.
Cpacey/json fixes plus
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We JSON.parse and JSON.stringify the cached results as necessary.
Fixes #3.