Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3530 Change revert terminal-run commands into normal commands w/ proper error handling #3789

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

3530 Change revert terminal-run commands into normal commands w/ proper error handling #3789

wants to merge 2 commits into from
+198 −19

Conversation

sergiolms
Copy link
Contributor

@sergiolms sergiolms commented Nov 21, 2024 •
edited
Loading

Description

This task creates the git revert commands to move away from runTerminalCommand

Solves #3530

Checklist

  • I have followed the guidelines in the Contributing document
  • My changes follow the coding style of this project
  • My changes build without any errors or warnings
  • My changes have been formatted and linted
  • My changes include any required corresponding changes to the documentation (including CHANGELOG.md and README.md)
  • My changes have been rebased and squashed to the minimal number (typically 1) of relevant commits
  • My changes have a descriptive commit message with a short title, including a Fixes $XXX - or Closes #XXX - prefix to auto-close the issue that your PR addresses

@sergiolms sergiolms self-assigned this Nov 21, 2024
@sergiolms sergiolms marked this pull request as draft November 21, 2024 14:05
@gitkraken gitkraken deleted a comment from Ppeepost4489 Nov 22, 2024
@sergiolms sergiolms force-pushed the feature/#3530_change_git-revert_command_to_normal_cmd branch from b3280b6 to 5d90ed8 Compare November 27, 2024 14:17
@sergiolms sergiolms marked this pull request as ready for review November 27, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@axosoft-ramint axosoft-ramint Awaiting requested review from axosoft-ramint

@eamodio eamodio Awaiting requested review from eamodio

Assignees

@sergiolms sergiolms

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sergiolms