Moving the empty text fix as some were getting through before #1311
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Firstly thanks for an awesome package!
We were getting intermittent errors when converting a series of Tables into powerpoint slides. After some investigation it was down to the way the table's content was being split across slides. There was already an effort to fill empty cells in the source code, however under certain circumstances it appears empty text entries were still in the currTableRow.
To ensure any empty entries were filled I've removed the earlier check that appeared to allow some to remain and instead loop through and fill any empty entries before finally committing the row. I've tested this within our code base and the issue is fixed. We'll continue to use the fix but want to contribute it back.
I believe this will also help with issues like: https://github.com/gitbrent/PptxGenJS/issues/1168 and https://github.com/gitbrent/PptxGenJS/issues/1048
Happy to provide any further information as needed.
Thanks