Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving the empty text fix as some were getting through before #1311

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lawtontom
Copy link

Firstly thanks for an awesome package!

We were getting intermittent errors when converting a series of Tables into powerpoint slides. After some investigation it was down to the way the table's content was being split across slides. There was already an effort to fill empty cells in the source code, however under certain circumstances it appears empty text entries were still in the currTableRow.

To ensure any empty entries were filled I've removed the earlier check that appeared to allow some to remain and instead loop through and fill any empty entries before finally committing the row. I've tested this within our code base and the issue is fixed. We'll continue to use the fix but want to contribute it back.

I believe this will also help with issues like: https://github.com/gitbrent/PptxGenJS/issues/1168 and https://github.com/gitbrent/PptxGenJS/issues/1048

Happy to provide any further information as needed.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants