-
Notifications
You must be signed in to change notification settings - Fork 647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bamboo/better error handling for media assets #1310
Open
urielSilva
wants to merge
57
commits into
gitbrent:master
Choose a base branch
from
pitch-io:bamboo/better-error-handling-for-media-assets
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Bamboo/better error handling for media assets #1310
urielSilva
wants to merge
57
commits into
gitbrent:master
from
pitch-io:bamboo/better-error-handling-for-media-assets
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow file extension to be passed
Support gradients for slide background
Use regex to determine file extension
Add shadow options to image properties
…ted-dependencies Fix vulnerabilities
Add image props - solidFill and fillOverlay
Fix shadow types: inner and none
Update dist
Add image blur
Allow external fonts to PPTX
adding fntdata file with spaces results into broken presentation
Remove spaces from fntdata filename
only override missing props on the text run, not just falsey ones
add pie chart explosion opt to charts
Return file size from writeFile fn
Support transparency for table borders
…erlink-rids-2 increment Rids correctly for SVGs
Remove invalid docstring
…about-images-which-2 add ex info to reject string
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current pptx export fails whenever a media asset fails to be loaded. This PR fixes that by adding a blank image whenever an asset fails to load.