Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persist slide numbers and placeholder formatting after generation #1276

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

rtyocum
Copy link

@rtyocum rtyocum commented Jul 19, 2023

Change Summary

Previously, after downloading a slide with slide numbers would only show on the slides generated, and not new ones generated by powerpoint, this fixes that

Change Description

Just needed a change of genXml for generating slide masters changing the line that disabled slideNumbers

Change Type

  • Bug fix
  • New feature
  • Documentation update

Motivation and Context

Powerpoints should be editable after the fact, and without this, it makes it more confusing.

Checklist before requesting a review

  • My code follows the style guidelines of this project
  • My changes generate no new eslint warnings
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have included code/tests that prove my fix is effective or that my feature works
  • I have used the "Run All Demos" feature on the browser demo and no errors were found

@rtyocum
Copy link
Author

rtyocum commented Jul 19, 2023

Placeholder formatting after download was also an issue, fixed here as well

@rtyocum rtyocum changed the title Persist slide numbers after generation Persist slide numbers and placeholder formatting after generation Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant