Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added custom 404 page [fixes #210] #226

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

sarthak-kumar-shailendra
Copy link
Contributor

@sarthak-kumar-shailendra sarthak-kumar-shailendra commented Oct 6, 2023

Have modified the custom 404 page. [Fixes #210]

Previous UI
Screenshot 2023-10-06 at 11 03 40 PM

Screenshot 2023-10-06 at 11 03 31 PM

New UI

Screenshot 2023-10-06 at 11 03 00 PM Screenshot 2023-10-06 at 11 03 21 PM

Have added translation for hindi as well

Screenshot 2023-10-06 at 11 21 48 PM

This UI renders when wrong chapter or verse is entered in URL and also in case the verse of the day is missing

@vercel
Copy link

vercel bot commented Oct 6, 2023

@sarthak-kumar-shailendra is attempting to deploy a commit to the Ved Vyas Foundation Team on Vercel.

A member of the Team first needs to authorize it.

@sarthak-kumar-shailendra
Copy link
Contributor Author

@samanyougarg

@sarthak-kumar-shailendra
Copy link
Contributor Author

Hare Krishna
pls review @samanyougarg

Copy link

vercel bot commented Jan 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
bhagavad-gita ✅ Ready (Inspect) Visit Preview Jan 20, 2024 6:09pm

@samanyougarg
Copy link
Member

Tried with /radheradhe but I don't get a 404 page:
CleanShot 2024-01-20 at 23 42 51@2x

@samanyougarg
Copy link
Member

Works for /chapters but there is too much padding below the image and above the footer. Additionally, the header should be visible on this page.

CleanShot 2024-01-20 at 23 44 08@2x

Copy link
Member

@samanyougarg samanyougarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Add a custom 404 page
2 participants