Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

step interval behaving like native number input field #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mattez
Copy link

@mattez mattez commented Jun 4, 2018

No description provided.

@gijsroge
Copy link
Owner

gijsroge commented Jun 4, 2018

Could you explain what this solves? Thanks!

@mattez
Copy link
Author

mattez commented Jun 4, 2018

It should respect min, max and step. So example:
max=10
min= 0
step=4

If you write "2" in the input and then hit "up button" it should input "4" (not "6" as now).
I was hasty. I have not tested it yet. I'll do it.

@gijsroge
Copy link
Owner

gijsroge commented Jun 4, 2018

Ah, completely missed that. Let me know if its ready, i'll test it myself and merge it. Thanks!

@mattez
Copy link
Author

mattez commented Nov 27, 2018

So I already tested. And IMHO it works fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants