Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Login Panic and Add Clone Derives #12

Merged
merged 12 commits into from
Nov 30, 2023
Merged

Fix Login Panic and Add Clone Derives #12

merged 12 commits into from
Nov 30, 2023

Conversation

gierens
Copy link
Owner

@gierens gierens commented Nov 30, 2023

This adds further error handling to lib::authentication::login and changes lib::Api::new to return Result<Api, UserError>.

This also adds derives of Clone to all public structs and enums.

Fixes #11

@gierens
feat(lib): derive Clone for all public enums and structs
a3c5e80 
Signed-off-by: Sandro-Alessio Gierens <sandro@gierens.de>
@gierens
refactor(lib): revise authentication::login to check succeeded
42313ea 
Signed-off-by: Sandro-Alessio Gierens <sandro@gierens.de>
@gierens
fix(lib): revise Api::new to return Result<(), UserError> from login
65aa0ea 
Signed-off-by: Sandro-Alessio Gierens <sandro@gierens.de>
@gierens
docs(lib): update example with unwrap of Api::new
3f51a0b 
Signed-off-by: Sandro-Alessio Gierens <sandro@gierens.de>
@gierens
docs(readme): update usage example with unwrap of Api::new
2827be1 
Signed-off-by: Sandro-Alessio Gierens <sandro@gierens.de>
@gierens
refactor(fuse): handle error response from Api::new
c12dc4c 
Signed-off-by: Sandro-Alessio Gierens <sandro@gierens.de>
@gierens
refactor(cli): handle error response from Api::new
4a02432 
Signed-off-by: Sandro-Alessio Gierens <sandro@gierens.de>
@gierens gierens self-assigned this Nov 30, 2023
@gierens gierens added bug Something isn't working rust Pull requests that update Rust code cli fuse and removed cli fuse labels Nov 30, 2023
@gierens
style(lib): fix missing , to make rustfmt happy
6fd0573 
Signed-off-by: Sandro-Alessio Gierens <sandro@gierens.de>
@gierens
style(lib): remove duplicate Clone derive on PageMinimal
d339b47 
Signed-off-by: Sandro-Alessio Gierens <sandro@gierens.de>
@gierens
test(lib): handle error response from Api::new
a43dbe0 
Signed-off-by: Sandro-Alessio Gierens <sandro@gierens.de>
@github-actions github-actions bot added the tests label Nov 30, 2023
@gierens
style(tests): add line break to make rustfmt happy
175e139 
Signed-off-by: Sandro-Alessio Gierens <sandro@gierens.de>
@gierens
docs(lib): add unwrap to Api::new call in page_get docstring
a4e67ac 
Signed-off-by: Sandro-Alessio Gierens <sandro@gierens.de>
@gierens gierens merged commit 89762ba into main Nov 30, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@gierens gierens

Labels
bug Something isn't working cli fuse lib rust Pull requests that update Rust code tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Login Panics for Wrong Credentials
1 participant
@gierens